Ok  so i want to upgrade something on my computer for xmas but i dont know what i was thinking either 

You don't need more RAM, 4GB is the max that Vista 32 can handle and XP. Upgrade your CPU...

I'd get a different video card too.

Any suggestions on what CPU or Video card or is what i have good?

You haven't mentioned how much you willing to spend ?!
That should give us a better idea of what we can suggest.

oh...yeah i would like to keep it around $200-250

You can buy my videocard for twice that.

"You can buy my videocard for twice that."

EVERYTHING!!!!........

Actually wait I'll get my brother

GTS 8800! man thats un-efficient

Thanks for acknowledging me "Snail". I really feel like I'm part of the community now.

Yeah ive decided to go with a new AMD Phenom 9850 2.5ghz Black Edition cpu and a nice Asus mobo to go with it

Ok since you're getting a new mobo and cpu I recommend getting an Intel CPU and an X58 mobo, AMD's just don't perform that great seriously and AMD mobos are also pretty unreliable to tell you the truth. Your best solution is to get the new Intel core i7 processor and and any x58 and for the video card I don't think a 1GB 4850 is necessary just get the 512MB as you won't see much of a difference between the two unless you will be gaming at an unbelievably high resolution.