Something went wrong. Try again later

Conmused

This user has not updated recently.

47 0 2 5
Forum Posts Wiki Points Following Followers

Conmused's forum posts

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

#1  Edited By Conmused

@szlifier: Hmm. That's a cleaner solution than what I'm using.

Currently I listen for an error on video images, then swap out the extension. If it errors again I throw in a placeholder. I'm using react, so it's all componentized and easy to throw in anywhere. Plus, it means I never have to worry about cropping... but at the cost of triggering a recalc on every single error.

Edit: Bah, apparently using background image like that would still trigger a repaint, and potentially throws it on images that don't need any help. ( source: http://csstriggers.com/ )

I'll need to think on this a bit more. Maybe I can listen for a request error on a background image property, or something?

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

#2  Edited By Conmused

There are a sizable number of results with broken images in /videos responses. It looks like the original upload file changed extensions at some point, but whatever the API hits never got updated. I did a quick run through the /videos endpoint, paginating through the first 1000 results of each video_type, discovering about 277 items (mostly trailers) with broken images. I can paste in the broken urls, if 277 links won't get me flagged as spam.

Example Results:

  • API Response (broken): http://static.giantbomb.com/uploads/scale_small/21/211414/2791948-screen+shot+2015-10-21+at+5.50.41+pm.png
  • Site URL (working): http://static.giantbomb.com/uploads/screen_small/21/211414/2791948-screen+shot+2015-10-21+at+5.50.41+pm.jpg

(I know the base urls are different, but screen_small isn't even an option in the api response. The problem lies with the file extension, not the rest of the path.)

They're almost all mac OSX screenshot files, or images named 'untitled', or 'Image'. Every broken file seems to be a png that needs to be a jpg. A handful have actual names, for example, the GOTY images from 2014. Unless taking a system screengrab is standard for uploading videos, I'm guessing someone had a process that routinely broke something within the API.

I planned on throwing in placeholders onError (or given the extension-pattern, I'd probably just try hot-swapping extensions first), so it's not like functionality or layout will break for my app. But is it possible to get these urls fixed?

Edits: Just being a little more clear.

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

@edgework: Also, is this currently in effect? Even spacing out my requests, the giantbomb.com/api page seems to show me at ~200 requests an hour per endpoint, rather than an evenly paced 3600.

(I hit the api faster than 1 request/second at various points last night, when my rate limiter went haywire. So, that could explain it.)

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

@edgework: Is this rate limiting based on endpoint, or the entire API? Just curious where to put my rate limiter.

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

Do we have a time frame? I have an idea, but my time is basically booked up until sunday.

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

Man of Steel: $48.3 million

Monsters University: $90.3 million

World War Z: $31.2 million

Total: $169.8 million

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

@pickassoreborn: Yup. I think they even addressed this once on the Bombcast, after another user saw coke using it for something.

Nothing wrong with stock art. After all, it looked pretty damn good when combined with the illustrations.

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

@djjoejoe: Heh. Yeah, so in my search for free vintage textures, I grabbed from a lot of sources. Pretty sure that's a remnant of an old blue-print sheet.

No Caption Provided

If @ryan wants that fixed/removed, here it is.

Avatar image for conmused
Conmused

47

Forum Posts

0

Wiki Points

5

Followers

Reviews: 0

User Lists: 1

#10  Edited By Conmused

@regal: Huh. Weird.

While I think I like the vinyl one more, I'm kind of glad @ryan picked this one. I want my toothy bomb... thing as big as possible on everyone's screen.