I have just sold my original Xbox one console

I have an HD TV - not an 4K one - we are looking at getting a 4K one but probably will be a couple more years,

Now I can’t really afford a Xbox one X now, £400 is just too much, but definitely can get a S - now will the S survive me until the next generation? How many years realistically are we looking until the next generation of consoles?

I just don’t want to get my S and then in a few years time, regret that I didn’t get an X because next generation will be like 5 years away

I doubt anyone here knows any better, myself included, but I’d say the next generation will be out by sometime 2021. Earliest guess for it would be the latter half of 2020.

Some have guessed it’d happen by the end of 2019, but that just seems way too early for me. Anything is possible, of course.

You'll be alright.